Fix size units #219
Merged
Fix size units #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it backward compatible? I am OK with limit changes because of the different unit, but will it work with |
|
Yes, it is. Verify on this runkit: https://runkit.com/5f46c24ab29d17001ad6a0c2/60620658b40dfa001aa9e18b. |
|
WHat do you think of moving to |
|
I would not do that. The base 10 notation is much easier to work with, i.e. convert between B <-> kB <-> MB. Linux and MacOS also display file size in base 10. Chrome network monitor also uses the base 10 notation. |
|
Released in 4.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced the
bytespackages withbytes-iecwhich uses the correct units.I also went through the project and replaced usages of
KBwithkBwhere appropriate.This fixes #218.