This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix recently found bugs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alkurbatov
commented
Oct 8, 2020
•
alkurbatov
commented
- Document how to launch old replays (OS X + Win).
- Split the input params with '--'. The observer's params go before '--', the game params go after '--'.
- Rebase on the newer API: Abort the game launch if we found an unexpected option.
- Integrate Google tests.
Brings the following: * Don't allow to start the game with invalid input args. * Fixes project compilation on the latest OS X. Signed-off-by: Alexander Kurbatov <Alexander.Kurbatov@acronis.com>
lladdy
approved these changes
Oct 8, 2020
|
Small refactoring needed for better testing later and there is missing delimiter in the windows example. |
added 2 commits
October 9, 2020 12:46
Observer has several options which conflict with SC2 (e.g. -p, --Path, vs -p, --port) and we can't explicitly specify which options should be used e.g. only in Observer and which only in SC2. As a result, such design causes confusion and weird behavior. Adopt the approach used by various command line tools and request division of cmdline options with the -- delimiter. Signed-off-by: Alexander Kurbatov <Alexander.Kurbatov@acronis.com>
Signed-off-by: Alexander Kurbatov <Alexander.Kurbatov@acronis.com>
|
Changes:
Not checked:
|
* Integrate Google testing framework into the project. * Add simple unit tests for ArgParser::splitInputOptions. Signed-off-by: Alexander Kurbatov <Alexander.Kurbatov@acronis.com>
|
Now with unit tests :) |
alkurbatov
commented
Oct 10, 2020
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.1) | |||
| cmake_minimum_required(VERSION 3.10) | |||
There was a problem hiding this comment.
Required to use gtest_discover_tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.