Skip to content
This repository has been archived by the owner on Jul 22, 2023. It is now read-only.

from https://github.com/aiarena/aiarena-client/pull/13 #26

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eladyaniv01
Copy link
Contributor

This PR will:

@eladyaniv01 eladyaniv01 requested a review from lladdy December 6, 2020 11:53
@lladdy
Copy link
Contributor

lladdy commented Dec 21, 2020

@eladyaniv01 this looks good. The one thing I can think to change is maybe have the ACStatus members be the same as their respective STATUS_TYPES and then just use enum.name to access them as a string.

e.g.

class ACStatus(Enum):
    idle = 1
    starting_game = 2
    playing_game = 3
    submitting_result = 4
    
    ---------------
    
    logger.info(status_enum.name)
    payload = {"status": status_enum.name}

You can also then just call status_enum status instead.

@lladdy lladdy requested a review from danielvschoor November 8, 2021 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants