Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): use correct username for devcontainer #138

Merged
merged 5 commits into from
Sep 20, 2023
Merged

fix(build): use correct username for devcontainer #138

merged 5 commits into from
Sep 20, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Sep 20, 2023 •
edited
Loading

Description

Didn't update the username after I changed the base image...

Review guidelines

Estimated Time of Review: 1.1 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested a review from JasperTan97 September 20, 2023 09:15
JasperTan97
JasperTan97 approved these changes Sep 20, 2023
View reviewed changes
Copy link

@JasperTan97 JasperTan97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all works. Good job!

@domire8 domire8 merged commit b045640 into develop Sep 20, 2023
7 checks passed
@domire8 domire8 deleted the fix/devcontainer branch September 20, 2023 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JasperTan97 JasperTan97 JasperTan97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @JasperTan97