feat: add IO states to state representation (cpp) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeberhard
reviewed
Mar 2, 2024
There was a problem hiding this comment.
Looks pretty good! A lot of boilerplate indeed and plenty of functions that might be a bit redundant, but it does fit in very nicely with other state types.
Just a shame that you mixed up the names analog and digital, but nothing some smart renaming won't fix!
source/state_representation/include/state_representation/IOState.hpp
Outdated
Show resolved
Hide resolved
source/state_representation/include/state_representation/AnalogIOState.hpp
Outdated
Show resolved
Hide resolved
source/state_representation/include/state_representation/StateType.hpp
Outdated
Show resolved
Hide resolved
|
Hahaha that is because I really thought analog is 1/0 and digital anything😁 well..... |
bpapaspyros
previously approved these changes
Mar 5, 2024
bpapaspyros
previously approved these changes
Mar 11, 2024
eeberhard
reviewed
Mar 26, 2024
source/state_representation/include/state_representation/StateType.hpp
Outdated
Show resolved
Hide resolved
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This turns out to be quite the PR, but its honestly a lot of boilderplate code and docstrings. The implementation of the classes follow our common patterns and don't add much complexity or new features. Same for the tests, it's the same lines as in the other state classes, to test all setters and getters.
Protocol and pybindings come in follow up PRs
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: