fix: refactor cmake project to deal with robot model dependencies #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 47ff4f4.
domire8
commented
Apr 9, 2024
| if (${_comp} STREQUAL "controllers" OR ${_comp} STREQUAL "robot_model") | ||
| # Find robot model dependencies if the corresponding component is needed | ||
| # FIXME: this should be done automatically | ||
| if (${_comp} STREQUAL "robot_model") | ||
| find_dependency(pinocchio) |
There was a problem hiding this comment.
Not sure. It built and ran correctly for me so I imagine pinocchio might be pulling it itself?
|
I've tested in in a backend and it seems to do the job! |
eeberhard
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves an issue where downstream projects had problems using the robot model library.
Thanks @LouisBrunner for the effort to clean this up!
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: