feat(controllers): add TF listener and broadcaster to controllers #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
force-pushed
the
feat/tf-devel
branch
from
b748d8b to
ed20342
Compare
bpapaspyros
force-pushed
the
feat/tf-devel
branch
from
20a1bfb to
f8eed86
Compare
|
Pending some tests on my end, but feel free to give feedback |
bpapaspyros
force-pushed
the
feat/tf-devel
branch
from
20064bd to
76313a4
Compare
domire8
approved these changes
Dec 5, 2024
|
ok, seems to work as intended. I would suggest we rebase and merge keeping these 3 commits in the history in main |
|
Perfect |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #169 and #170, this PR adds helper functions to use TF listeners and broadcasters in controllers.
Description
This PR solves the issue by replicating the necessary functions as originally designed in
ComponentInterfaceReview guidelines
Estimated Time of Review: 15 minutes
Checklist before merging:
Related issues
Blocked by:
Blocks: