Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: copy python packages into /usr instead of ~ros2 to avoid permission issues #69

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

LouisBrunner
Copy link
Contributor

Description

Part of aica-technology/docker-images#78

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use that to test if it works as expected once control libraries is merged or did you already do that locally?

@LouisBrunner
Copy link
Contributor Author

Should we use that to test if it works as expected once control libraries is merged or did you already do that locally?

I used a packaged backend, moved all of the ~ros2/.local/lib/python3.10/site-packages to /usr/lib/python3.10/dist-packages and ran python -c 'import clproto' and it found the library.
On the other hand, I built this image and checked that the packages were correctly copied to /usr/lib/python3.10/dist-packages.

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LouisBrunner LouisBrunner merged commit 1c76cbd into main Feb 20, 2024
3 checks passed
@LouisBrunner LouisBrunner deleted the feat/py-usr branch February 20, 2024 20:27
@domire8 domire8 mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants