Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: pybind readme example #70

Merged
merged 3 commits into from
Mar 13, 2024
Merged

docs: pybind readme example #70

merged 3 commits into from
Mar 13, 2024

Conversation

JasperTan97
Copy link
Contributor

Description

This PR solves the issue by adding a detailed example about the issue, as well as the added benefit of an example code to use the python bindings.

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@JasperTan97 JasperTan97 requested a review from domire8 March 12, 2024 10:32
@JasperTan97 JasperTan97 linked an issue Mar 12, 2024 that may be closed by this pull request
Add examples for handling strings and bytes with python bindings #67
Closed
domire8
domire8 reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two nitpicks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JasperTan97 and others added 2 commits March 13, 2024 13:36
@JasperTan97 @domire8
Update README.md 1
9b53c13 
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
@JasperTan97 @domire8
Update README.md 2
3611d06 
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
domire8
domire8 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JasperTan97 JasperTan97 merged commit 36ee3cf into main Mar 13, 2024
3 checks passed
@JasperTan97 JasperTan97 deleted the feat/pybind-example branch March 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domire8 domire8 domire8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples for handling strings and bytes with python bindings
2 participants
@JasperTan97 @domire8