Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MDB and remove package-lock #20

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Update MDB and remove package-lock #20

merged 4 commits into from
Aug 23, 2019

Conversation

Aichnerc
Copy link
Member

@Aichnerc Aichnerc commented Aug 23, 2019 •
edited
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Aichnerc and others added 3 commits August 23, 2019 09:31
@Aichnerc
Update MDB React
9e8d468 
MDB React has been updated within the
package.json file, while also making sure
the latest minor version is being pulled
every time someone does npm install.
@Aichnerc
Update version
ffb2062 
The version has been updated.
@kleberbaum
Merge pull request #18 from aichner/update-mdb-react-1
f8c5e9d 
Update mdb react 1
@Aichnerc Aichnerc added the enhancement New feature or request label Aug 23, 2019
@Aichnerc Aichnerc requested a review from kleberbaum August 23, 2019 07:54
@Aichnerc Aichnerc self-assigned this Aug 23, 2019
@Aichnerc
Remove package-lock from GitHub
452d4a1 
The package-lock file has been added to the
gitignore file to prevent future issues for people
who clone our repository.
Ref: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5
@Aichnerc Aichnerc force-pushed the remove-package-lock-1 branch from 0c40346 to 452d4a1 Compare August 23, 2019 08:05
@Aichnerc Aichnerc changed the title Remove package-lock from GitHub Update MDB and remove package-lock Aug 23, 2019
kleberbaum
kleberbaum approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.
63454038-4c67b600-c44a-11e9-931a-4e461b3a89bc

@kleberbaum kleberbaum merged commit 12b8eb4 into master Aug 23, 2019
This was referenced Aug 23, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

Assignees

@Aichnerc Aichnerc

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aichnerc @kleberbaum