Skip to content

Commit

Permalink
fix: remix warnings (#969)
Browse files Browse the repository at this point in the history
* init

* init

* remove log

* init
  • Loading branch information
Aslemammad authored Feb 24, 2024
1 parent 94e3ebe commit 535669f
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/compiler/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,20 @@ interface CompilerOutput {
map: BabelFileResult['map'];
}

let ssr = false

async function compile(
id: string,
code: string,
options: Options,
telemetryInstance: MillionTelemetry,
isServer?: boolean,
): Promise<CompilerOutput> {
if (isServer) {
// for frameworks like remix, even for client, we need to return react-server
ssr = true
}

displayIntro(options);

const plugins: ParserOptions['plugins'] = [
Expand Down Expand Up @@ -52,7 +59,7 @@ async function compile(
{
telemetry: telemetryInstance,
log: options.log,
server: isServer,
server: ssr,
hmr: options.hmr,
auto: options.auto,
rsc: options.rsc,
Expand Down

0 comments on commit 535669f

Please sign in to comment.