Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Million Lint issue with react version #1070

Open
1 task
MiltonAkash opened this issue Jul 3, 2024 · 6 comments
Open
1 task

Million Lint issue with react version #1070

MiltonAkash opened this issue Jul 3, 2024 · 6 comments

Comments

@MiltonAkash
Copy link

What version of million are you using?

1.0.0-rc.76

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

image Vite has this issue. I have only react 17 but it is trying to use react-dom/client which is react 18 specific.

What's the expected result?

asdf

Link to Minimal Reproducible Example

https:/asdfasfda/asfasfd.asdf

Participation

  • I am willing to submit a pull request for this issue.
Copy link

github-actions bot commented Jul 3, 2024

Thanks for opening this issue! A maintainer will review it soon.

@deansimcox
Copy link

I'm seeing the same error, also using 1.0.0-rc.76

@deansimcox
Copy link

Looks like a duplicate of #1062

@vsvamsi1
Copy link

Any update on this, we are not able to use this on a React version 17.

@Gigaxel
Copy link

Gigaxel commented Aug 22, 2024

a temporary fix that worked for me was to just modify in node_modules/@million/lint/dist/runtime-dev/index.mjs

the line where react-dom/client was referenced, to react-dom

@aidenybai
Copy link
Owner

Noted, looking into this now @deansimcox @vsvamsi1 @Gigaxel @MiltonAkash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants