Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$35] Support React 16 + 17 #534

Closed
1 task done
aidenybai opened this issue Aug 16, 2023 · 20 comments · Fixed by #537
Closed
1 task done

[$35] Support React 16 + 17 #534

aidenybai opened this issue Aug 16, 2023 · 20 comments · Fixed by #537

Comments

@aidenybai
Copy link
Owner

Describe the feature

Currently Million.js supports React 18. It would be nice to support React 16/17 builds.

Additional information

  • Would you be willing to help implement this feature?
@aidenybai
Copy link
Owner Author

/bounty $35

@algora-pbc
Copy link

algora-pbc bot commented Aug 16, 2023

💎 $35 bounty created by aidenybai
🙋 If you start working on this, comment /attempt #534 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #534 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to aidenybai/million!

Attempt Started (GMT+0) Solution
🟢 @rishi-raj-jain Aug 16, 2023, 9:21:32 PM #537

@aidenybai aidenybai changed the title Support React 16 + 17 [$25] Support React 16 + 17 Aug 16, 2023
@aidenybai aidenybai changed the title [$25] Support React 16 + 17 [$35] Support React 16 + 17 Aug 16, 2023
@rishi-raj-jain
Copy link
Contributor

rishi-raj-jain commented Aug 16, 2023

@aidenybai

/attempt #534

this'd just involve supporting it in https://github.com/aidenybai/million/tree/main/packages/react & react-server, right?

Options

@aidenybai
Copy link
Owner Author

Yes

@rishi-raj-jain
Copy link
Contributor

Thanks, on it!

@rishi-raj-jain
Copy link
Contributor

How do I validate if my fixes are correct?

@aidenybai
Copy link
Owner Author

aidenybai commented Aug 16, 2023

@rishi-raj-jain create a new vite project. use react 17 + react-dom 17. check if it works. then try with react 18. if it works on both, you can get the bounty

@rishi-raj-jain
Copy link
Contributor

@aidenybai

On it, thanks for the direction!

@rishi-raj-jain
Copy link
Contributor

vite-million-18.zip

Works fine with v18, breaks with v16 and v17 for react-dom errors.

@rishi-raj-jain
Copy link
Contributor

Ohkay, the only problem is of react-dom/client and shall be using react-dom in react < 18. Working on that.

@shubhamsingh259
Copy link

I have started working on that issues. I have steuped vite with react 18 and is also supported in react 16/17. Kindly make sure Is it right? then I can share zip file on that

@shubhamsingh259
Copy link

@aidenybai Please guide me Am i right?

@algora-pbc
Copy link

algora-pbc bot commented Aug 17, 2023

💡 @rishi-raj-jain submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

@Timonwa
Copy link
Contributor

Timonwa commented Aug 17, 2023

Hi @shubhamsingh259. You are right. You are to confirm that Million.js works in your vite app without errors when you use v16, v17 and v18 of React and React DOM. Once that is done, open a PR and claim the bounty.

@shubhamsingh259
Copy link

ok thanks

@algora-pbc
Copy link

algora-pbc bot commented Aug 18, 2023

🎉🎈 @rishi-raj-jain has been awarded $35! 🎈🎊

@shubhamsingh259
Copy link

I have created vite with react18 project. I have also intsalled million.js in vite+react project.
[https://github.com/shubhamsingh259/react-18.git]

@shubhamsingh259
Copy link

Please check this repository and kindly guide me. Am I right?.

@shubhamsingh259
Copy link

shubhamsingh259 commented Aug 18, 2023 via email

@joeyfigaro
Copy link

joeyfigaro commented Nov 29, 2024

What version was this released in? 2.6.0-beta.0 is not a valid tag on npm it looks like. Neither is 2.6.0.

Disregard–looks like I'm looking for @million/lint

Still not sure which version I should use for React v17 quite yet.

For anyone else stumbling here–see #1070 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants