Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji picker added #657

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Emoji picker added #657

merged 4 commits into from
Oct 4, 2023

Conversation

Roar022
Copy link
Contributor

@Roar022 Roar022 commented Oct 4, 2023

Description of Changes:

In this PR, I have implemented a feature that allows users to insert emojis in between their text input using React, million.js, and TypeScript. This feature enhances the user experience by adding a fun and expressive way to convey emotions and reactions in text.

Why it should be merged:

  • Improved User Experience: Emojis are a widely recognized form of expression in modern communication. By enabling users to easily insert emojis into their text input, we enhance the overall user experience and make the application more engaging and user-friendly.

  • Expressive Communication: Emojis provide a way for users to convey emotions and reactions effectively, which is particularly important in social or messaging applications. This feature enables users to express themselves more authentically.

  • Bug-Free Implementation: I have thoroughly tested the feature to ensure it functions as intended and does not introduce any new bugs or issues. This ensures that merging this PR will not negatively impact the existing codebase.

Resolves #620

Demo Video:

Emoji-picker.mp4
  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Additional Note:

I believe that merging this PR will bring a valuable addition to our project, enhancing user experience and further solidifying our repository's reputation for innovation and user-friendly features. I look forward to feedback and collaboration from the team to refine and finalize this enhancement. Thank you for considering this PR.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:55pm
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:55pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:55pm

@Timonwa
Copy link
Contributor

Timonwa commented Oct 4, 2023

Hi @Roar022, you seem to be having a build error, that is why this is failing. could you run pnpm run build on your local host, to view the errors and then try to fix them?

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @Roar022 😁. Can you maybe try the things @Timonwa suggested to maybe track down why the deployment of your PR is failing?

@Roar022
Copy link
Contributor Author

Roar022 commented Oct 4, 2023

@Timonwa @tobySolutions I have Fixed the bug. Please review my PR.

@tobySolutions
Copy link
Contributor

Awesome! Reviewing now

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! LGTM!!!

@tobySolutions tobySolutions merged commit d457a59 into aidenybai:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Emoji Picker
3 participants