Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kitchen sink age calculator #758

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat: kitchen sink age calculator #758

merged 1 commit into from
Oct 19, 2023

Conversation

chukwuani
Copy link
Contributor

@chukwuani chukwuani commented Oct 18, 2023 •
edited by tobySolutions
Loading

Please describe the changes this PR makes and why it should be merged:
Added an age calculator to the kitchen.
Resolves #743

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:43pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:43pm

tobySolutions
tobySolutions approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions tobySolutions merged commit 255ac38 into aidenybai:main Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobySolutions tobySolutions tobySolutions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Age Calculator
2 participants
@chukwuani @tobySolutions