Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen-Sink : Add number-guessing game #778

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

sukritmalpani
Copy link
Contributor

@sukritmalpani sukritmalpani commented Oct 23, 2023

Please describe the changes this PR makes and why it should be merged:

An interesting game of number guessing implemented using million.

Resolves #771

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 11:25am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 11:25am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6612551011

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6580687542: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks awesome.

@tobySolutions tobySolutions merged commit 4e3fb64 into aidenybai:main Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink : Number Guessing
3 participants