Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Data Converter in Kitchen Sink #786

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

lalitkumawat1m
Copy link
Contributor

@lalitkumawat1m lalitkumawat1m commented Oct 24, 2023

Please describe the changes this PR makes and why it should be merged:
Added Data Converter in Kitchen Sink

Resolves #764

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 5:04am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 5:04am

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🙌

Petabyte = "PB",
}

const DataConverter: React.FC = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your component doesn't use Million though. Can you maybe check this out? Use the block function from Millon

@lalitkumawat1m
Copy link
Contributor Author

Hey @tobySolutions, I have added a block function. Could you please check now?

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions
Copy link
Contributor

Good work @lalitkumawat1m!

@tobySolutions tobySolutions merged commit d3e4475 into aidenybai:main Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Data Converter
2 participants