-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Data Converter in Kitchen Sink #786
feat: Added Data Converter in Kitchen Sink #786
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🙌
Petabyte = "PB", | ||
} | ||
|
||
const DataConverter: React.FC = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your component doesn't use Million though. Can you maybe check this out? Use the block
function from Millon
Hey @tobySolutions, I have added a block function. Could you please check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Good work @lalitkumawat1m! |
Please describe the changes this PR makes and why it should be merged:
Added Data Converter in Kitchen Sink
Resolves #764
Status
Semantic versioning classification: