Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Sink: Todolist bugs fixed #821

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Kitchen Sink: Todolist bugs fixed #821

merged 1 commit into from
Nov 11, 2023

Conversation

oliverloops
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Two important bugs were resolved, one to correctly clear the input after adding a new task and the other related to an items deletion issue

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 8:35am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 8:35am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6768198197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6738886424: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@oliverloops
Copy link
Contributor Author

I see the Automated Responses task failing, but the code sample and changes we're correctly tested

@tobySolutions
Copy link
Contributor

Hmm, gonna review this soon. Thanks @oliverloops. That's weird.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @oliverloops

@tobySolutions tobySolutions merged commit 0b9ee21 into aidenybai:main Nov 11, 2023
2 of 4 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants