Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the tests for the geometric_model #199

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

Moanalengkeek
Copy link
Collaborator

Description

Summary of changes

  • The tests somehow went missing in the transfer of the geometric model from the fork to a separate branch within main. Hence, they've been added within the file actor_builder_tests

Resolved Issues

Related Pull Requests

Copy link

github-actions bot commented Jan 22, 2024

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py33197%49
   paseos.py1441292%67–68, 145–146, 203, 218, 236, 245, 263, 294, 302–305
paseos/activities
   activity_manager.py43393%46, 74, 157
   activity_processor.py58198%121
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py1852785%23–29, 32, 222–224, 251–253, 298–307, 474, 531, 559, 571–575, 582–583, 590–591
   base_actor.py1281886%82, 104, 120, 167, 207–209, 230, 239, 256, 277, 283–286, 292, 307, 362
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/central_body
   central_body.py65592%68, 177–178, 186–187
   is_in_line_of_sight.py581279%106–123, 167, 187
   mesh_between_points.py35294%64, 72
   sphere_between_points.py26869%35–38, 48–51, 63–64
paseos/communication
   get_communication_window.py23291%38, 64
paseos/geometric_model
   geometric_model.py28293%101–102
paseos/power
   charge_model.py16194%49
   discharge_model.py7271%22, 34
paseos/tests
   activity_test.py57395%90, 93–94
   communication_window_test.py49198%176
   eclipse_test.py10190%20
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py62494%143–146
   mesh_test.py119397%118, 136, 144
   thermal_model_test.py30197%61
   visualization_test.py18194%28
paseos/utils
   check_cfg.py611870%31, 40, 46, 60–62, 67, 70–72, 75–77, 80–82, 98, 103
   operations_monitor.py71396%127–130
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%29–32
   space_animation.py2152389%108–109, 124, 147–148, 182, 206–213, 219, 329, 352–354, 359, 368–369, 373, 409, 415–416, 447, 461–472
TOTAL219517992% 

Tests Skipped Failures Errors Time
37 0 💤 0 ❌ 0 🔥 1m 0s ⏱️

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the @Property decorator at line 81 in geometric_model? I just noticed itreviewing your code. P There is no setter or deleter, so it looks weird to me. Please remove it and doublecheck. Let me know. For the rest, it looks good.

@GabrieleMeoni GabrieleMeoni merged commit a2ad9fb into student Jan 23, 2024
0 of 3 checks passed
@GabrieleMeoni GabrieleMeoni deleted the geometrical-model-tests branch January 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants