Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efficiency update to typology members in alerts #42

Merged
merged 14 commits into from
Jan 16, 2025
Merged

efficiency update to typology members in alerts #42

merged 14 commits into from
Jan 16, 2025

Conversation

johanos1
Copy link
Collaborator

@johanos1 johanos1 commented Jan 15, 2025 •
edited
Loading

Description

Summary of changes

  • Update to typology member choice.
  • Updated workflow to install environment from toml and updated paths
  • Updated toml to reflect requirements.txt

Resolved Issues

How Has This Been Tested?

  • It is much faster to create data.
  • Tests now pass.

@johanos1 johanos1 self-assigned this Jan 15, 2025
@johanos1 johanos1 requested a review from TheColdIce January 15, 2025 21:24
TheColdIce
TheColdIce approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@TheColdIce TheColdIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@johanos1 johanos1 merged commit a1dfac3 into main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheColdIce TheColdIce TheColdIce approved these changes

Assignees

@johanos1 johanos1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It takes long to create datasets
2 participants
@johanos1 @TheColdIce