-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The app store displays confusing incompatibility warning during app installation #100
Comments
This might not be fully resolved. |
This was referenced Feb 8, 2023
unkcpz
added a commit
to aiidalab/aiidalab
that referenced
this issue
Mar 1, 2023
This is the more direct cause of aiidalab/aiidalab-home#100 In the package, there is already a context manager _show_busy provide to hold the display before the operations are running. However, this context manager only set the `self.busy` to a bool, which will be overridden unexpectedly if the _show_busy is embedded in itself. This happened for install_app, updata_app and uninstall_app, they are supposed to use _show_busy to prevent information to be displayed, but inside these function also call refresh which have another _show_busy. I add a counter to properly set the busy traitlets. It is False (which means not busy) when it counts down to zero.
unkcpz
added a commit
that referenced
this issue
Mar 1, 2023
Fixes #100 The compatible info will be shown during the installation, which is not the expected behavior. The compatible info is only shown for the app installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed behavior
When installing a new app, the app store will show a confusing warning:
See also screenshot:
Expected behavior
The app store should not check compatibility during the installation, but only after the installation has completed.
The text was updated successfully, but these errors were encountered: