Remove not depracated git_setup.ipynb #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this actually looks kinda useful. Perhaps this could be a part of the new "Settings" tab that we've discussed as part of making AWB into a library. |
|
Why do you think it is useful? I think it basically provides for AiiDAlab user git access but in my opinion, the "production" AiiDAlab user doesn't need this and we (developers) need git setup but since we introduce the aiidalab-launch to start the local development environment this again not been used. |
|
Yeah, I guess for production this shouldn't be there. |
danielhollas
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
LGTM but please wait what @yakutovicha has to say before we delete this.
yakutovicha
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yakutovicha This notebook is not used anymore, correct?