Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress should scroll for single app manager #146

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 9, 2023

No description provided.

@unkcpz
Copy link
Member Author

unkcpz commented Mar 9, 2023

I don't know why this is only happening now. I think previously it is all fine. Do you have any clue why I see the app manager in the box if I don't apply this change?

@danielhollas
Copy link
Contributor

Do you have any clue why I see the app manager in the box if I don't apply this change?

I dunno. Please include screenshots (before and after the changes).

@unkcpz
Copy link
Member Author

unkcpz commented Mar 9, 2023

I cannot reproduce it on my laptop, will try tomorrow on my workstation. I change my screen this morning to a higher resolution, dont know if it is the reason.

@unkcpz unkcpz marked this pull request as draft March 9, 2023 23:06
@danielhollas
Copy link
Contributor

I just experienced this when I added some debugging output after the app.

obrazek

@unkcpz
Copy link
Member Author

unkcpz commented Mar 15, 2023

I think we didn't have this issue because the single app widget is always not very big. With some output in the cell, the issue will happen. The change is needed.

@danielhollas thanks for checking and approving.

@unkcpz unkcpz marked this pull request as ready for review March 15, 2023 01:44
@unkcpz unkcpz merged commit 39cc819 into main Mar 15, 2023
@unkcpz unkcpz deleted the home-app-output-area branch March 15, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants