Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable prompt for appstore and single app page #154

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jul 18, 2023

This is a follow up on #141 where we disabled the alert prompt when leaving the home page. We've been using it for quite a while since and haven't noticed any issues so it's time to apply to other apps / pages.

In the future, we should ideally apply this fix directly in Appmode, but that will require more work so for now here's just a simple hotfix.

Closes #133

@danielhollas danielhollas marked this pull request as ready for review July 24, 2023 12:38
@danielhollas
Copy link
Contributor Author

@unkcpz by the way, if you haven't already, you might want to apply this fix for the QeApp as well...

Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - seems to work well. Thanks, @danielhollas!

@danielhollas danielhollas merged commit 0f6e61a into main Jul 26, 2023
2 checks passed
@danielhollas danielhollas deleted the disable-prompts-everywhere branch July 26, 2023 12:45
@unkcpz
Copy link
Member

unkcpz commented Jul 27, 2023

@unkcpz by the way, if you haven't already, you might want to apply this fix for the QeApp as well...

Yes, worth to do it. I think this is also worth to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the confirmation dialog for static pages
3 participants