Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the dependency installation process to the user. #65

Merged
merged 7 commits into from
Aug 26, 2021

Conversation

yakutovicha
Copy link
Member

@yakutovicha yakutovicha commented Aug 3, 2021

This is how it looks like:

Screenshot 2021-08-03 at 12 26 43

@yakutovicha yakutovicha marked this pull request as draft August 3, 2021 10:24
@yakutovicha
Copy link
Member Author

this PR depends on aiidalab/aiidalab#198

@yakutovicha yakutovicha marked this pull request as ready for review August 3, 2021 16:23
@csadorf
Copy link
Member

csadorf commented Aug 24, 2021

@yakutovicha Is this ready for review?

@yakutovicha
Copy link
Member Author

@yakutovicha Is this ready for review?

yes, sorry, forgot to put you as the reviewer.

home/widgets.py Outdated Show resolved Hide resolved
@csadorf
Copy link
Member

csadorf commented Aug 26, 2021

@yakutovicha Please make sure to explicitly re-request my review once you are done with applying revisions. Thank you.

home/widgets.py Outdated Show resolved Hide resolved
home/widgets.py Outdated Show resolved Hide resolved
home/widgets.py Outdated Show resolved Hide resolved
home/widgets.py Outdated Show resolved Hide resolved
Copy link
Member

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@yakutovicha yakutovicha merged commit 3aa84cf into develop Aug 26, 2021
@yakutovicha yakutovicha deleted the feature/dependency-installation-log branch August 26, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants