Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min version of aiidalab dependency. #87

Merged

Conversation

yakutovicha
Copy link
Member

fixes #76

The min version of aiidalab is set to be >= 21.10.2.
Previously, logo was an attribute of the _AiidaLabApp class.
Now it is a part of its metadata.

The min version of aiidalab is set to be >= 21.10.2.
Previously, `logo` was an attribute of the `_AiidaLabApp` class.
Now it is a part of its metadata.
@yakutovicha yakutovicha force-pushed the maintain/increase-aiidalab-dependency-min-version branch from 277e4de to 3575728 Compare May 19, 2022 09:37
@yakutovicha yakutovicha requested a review from unkcpz May 19, 2022 09:38
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! @yakutovicha

@yakutovicha yakutovicha merged commit 20e4a77 into develop May 19, 2022
@yakutovicha yakutovicha deleted the maintain/increase-aiidalab-dependency-min-version branch May 19, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app metadata logo key error
2 participants