Add from_nodes class method to instantiate a BandsPdosModel from AiiDA nodes
#1037
Conversation
edan-bainglass
force-pushed
the
bands-pdos-model-from-nodes
branch
from
1bc45fe to
ea6a842
Compare
edan-bainglass
force-pushed
the
bands-pdos-model-from-nodes
branch
from
49c6146 to
bfb35e4
Compare
|
@AndresOrtegaGuerrero a colleague was complaining quite a bit about not being able to use the app's widgets to quickly plot some electronic structure stuff. This PR is trying to address this, while also starting to address #818. At the moment, I am providing the means to easily create the MVC component from workflow nodes. I will probably commit a change in a bit to allow also from the calculation nodes, which is the colleague's case. |
| @@ -7,31 +7,9 @@ | |||
|
|
|||
|
|
|||
| class BandsPdosWidget(ipw.VBox): | |||
| """ | |||
| A widget for plotting band structure and projected density of states (PDOS) data. | |||
There was a problem hiding this comment.
If you are removing mos of the Docstring, add it where it should be , so is easy for someone in the future to do changes
There was a problem hiding this comment.
Agreed, but later, once we understand the design better 👍 This is not done.
There was a problem hiding this comment.
Same goes for tests. No need to comment on them not passing. I'll adjust w.r.t the final design.
| @@ -79,6 +82,37 @@ def __init__(self, *args, **kwargs): | |||
| lambda _: self._has_pdos or self.needs_projections_controls, | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_nodes( | |||
| cls, | |||
There was a problem hiding this comment.
I think you should include some doc string here, to explain why these decisions, and that the bands conditionals is to guarantee backwards compatibility
There was a problem hiding this comment.
Sure. Once the design is settled, docstrings 👍
This PR adjusts the bands-pdos MVC component by removing the required bands/pdos
AttributeDictnodes from the widget constructor and adding afrom_nodesclass method to the model that takes care of theAttributeDictextraction. This is one in several future PRs that aims to both make this MVC component more usable outside of the app (for local plotting of the electronic structure), and prepare the component for the future unification of electronic structure results tabs.