Skip to content

Commit

Permalink
Bump traitlets to v5.9 (#526)
Browse files Browse the repository at this point in the history
New version of traitlets contains optimizations
that significantly speed up loading of the app.
* Bump actions/checkout to v4
* Run pip install without -U in tests
* Bump pytest-docker
* pip --no-cache-dir
* Bump pytest
---------
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
  • Loading branch information
danielhollas authored Nov 9, 2023
1 parent ac96dc6 commit 665375a
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v4
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
steps:

- name: Check out app
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
Expand All @@ -64,7 +64,7 @@ jobs:
**/pyproject.toml
**/requirements*.txt
- name: Install package
- name: Install package test dependencies
run: pip install -e .[dev]

- name: Set jupyter token env
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
steps:

- name: Check out app
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

steps:

- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v2
Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ filterwarnings = [
# TODO: This comes from a transitive dependency of optimade_client
# Remove this when this issue is addressed:
# https://github.com/CasperWA/ipywidgets-extended/issues/85
'ignore:metadata.*trait.*<traitlets.traitlets.Unicode object:DeprecationWarning:traitlets',
'ignore::DeprecationWarning:ipywidgets_extended',
'ignore:metadata.*traitlets.traitlets.Unicode object:DeprecationWarning:traitlets',
# For some reason we get this error, perhaps because we do
# not unload the AiiDA profile? Let's ignore this for now.
# E pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function Popen.__del__>
Expand All @@ -24,6 +25,7 @@ filterwarnings = [
# E _warn("subprocess %s is still running" % self.pid,
# E ResourceWarning: subprocess 382685 is still running
'ignore:Exception ignored in:pytest.PytestUnraisableExceptionWarning:_pytest',
'ignore::DeprecationWarning:pytest_html',
'ignore::DeprecationWarning:jupyter_client',
'ignore::DeprecationWarning:selenium',
'ignore::DeprecationWarning:pytest_selenium',
Expand Down
8 changes: 6 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ install_requires =
bokeh~=2.0
humanfriendly~=10.0
ipytree~=0.2
traitlets~=5.9.0
ipywidgets~=7.7
widgetsnbextension<3.6.3
more-itertools~=8.0
Expand All @@ -45,9 +46,12 @@ dev =
bumpver==2021.1114
pgtest==1.3.1
pre-commit==2.10.1
pytest~=6.2
# NOTE: pytest-selenium currently incompatible with pytest>=7.2
# Maybe could be made to work by installing 'py' dependency, see:
# https://docs.pytest.org/en/7.4.x/changelog.html#pytest-7-2-0-2022-10-23
pytest~=7.1.0
pytest-cov~=4.0
pytest-docker~=1.0
pytest-docker~=2.0
pytest-selenium~=4.0
selenium~=4.7.0
webdriver-manager~=3.8
Expand Down
2 changes: 1 addition & 1 deletion tests_notebooks/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def notebook_service(docker_ip, docker_services, aiidalab_exec):
aiidalab_exec("chmod -R a+rw /home/jovyan/apps/aiidalab-widgets-base", user="root")

# Install AWB with extra dependencies for SmilesWidget
aiidalab_exec("pip install -U .[smiles]")
aiidalab_exec("pip install --no-cache-dir .[smiles]")

# `port_for` takes a container port and returns the corresponding host port
port = docker_services.port_for("aiidalab", 8888)
Expand Down

0 comments on commit 665375a

Please sign in to comment.