Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #92

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Release v1.0.0 #92

merged 1 commit into from
Nov 28, 2023

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Nov 28, 2023

Bump version number to 1.0.0

Updating the Changelog.

Removing the documentation under development banner.

Updating the Changelog.

Removing the documentation under development banner.
@JPchico JPchico linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47b1a4d) 85.51% compared to head (df152b8) 85.51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #92   +/-   ##
========================================
  Coverage    85.51%   85.51%           
========================================
  Files           19       19           
  Lines         1622     1622           
========================================
  Hits          1387     1387           
  Misses         235      235           
Flag Coverage Δ
pytests 85.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPchico
Copy link
Collaborator Author

JPchico commented Nov 28, 2023

@chrisjsewell , @sphuber any comments before merging this?
I assume that I can make the tag and release directly from the release github tab right?

Copy link
Member

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work @JPchico . Great to see this milestone!

I assume that I can make the tag and release directly from the release github tab right?

Not sure what you mean with this. What I would do is the following. After you merge the PR, do the following in your local clone:

git fetch --all
git checkout develop
git pull origin develop
git tag v1.0.0
git push --tags

Essentially you create the tag on the latest commit on develop and push it. This will trigger the CD workflow which will build and push the package to PyPI.

@chrisjsewell
Copy link
Member

All looks good cheers 🎉
You need to merge develop in to master before releasing.
You just make the release from GitHub and it creates the tag for you.

Then we can delete develop/development branches and work straight from master.

@chrisjsewell
Copy link
Member

After you merge the PR, do the following in your local clone ...

Nope 👎 😉 just do it from GitHub

@JPchico JPchico merged commit 2e3bfce into aiidaplugins:develop Nov 28, 2023
10 checks passed
@JPchico JPchico deleted the release-1.0.0 branch November 28, 2023 15:07
@JPchico JPchico mentioned this pull request Nov 28, 2023
@JPchico
Copy link
Collaborator Author

JPchico commented Nov 28, 2023

Thank you for your help @chrisjsewell and @sphuber ! The release is done! If something comes up just let me know!

@chrisjsewell
Copy link
Member

Think the deployment workflow needs updating, I can do it in a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make release 1.0.0
3 participants