-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.0.0 #92
Release v1.0.0 #92
Conversation
Updating the Changelog. Removing the documentation under development banner.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #92 +/- ##
========================================
Coverage 85.51% 85.51%
========================================
Files 19 19
Lines 1622 1622
========================================
Hits 1387 1387
Misses 235 235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@chrisjsewell , @sphuber any comments before merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work @JPchico . Great to see this milestone!
I assume that I can make the tag and release directly from the release github tab right?
Not sure what you mean with this. What I would do is the following. After you merge the PR, do the following in your local clone:
git fetch --all
git checkout develop
git pull origin develop
git tag v1.0.0
git push --tags
Essentially you create the tag on the latest commit on develop
and push it. This will trigger the CD workflow which will build and push the package to PyPI.
All looks good cheers 🎉 Then we can delete develop/development branches and work straight from master. |
Nope 👎 😉 just do it from GitHub |
Thank you for your help @chrisjsewell and @sphuber ! The release is done! If something comes up just let me know! |
Think the deployment workflow needs updating, I can do it in a minute |
Bump version number to 1.0.0
Updating the Changelog.
Removing the documentation under development banner.