Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp2k: protocols revision #263

Merged
merged 23 commits into from
Jul 11, 2023
Merged

Cp2k: protocols revision #263

merged 23 commits into from
Jul 11, 2023

Conversation

yakutovicha
Copy link
Contributor

  1. Set the electronic temperature to 710.5 K
  2. Set MGRID CUTOFF to 1800.
  3. Set REL_CUTOFF to 80.
  4. Set NGRIDS to 4.
  5. Remove initial magnetisation of the atoms (not used).
  6. Remove unused files: dftd3.dat and xTB_parameters.

@yakutovicha yakutovicha force-pushed the cp2k/protocols-revision branch from f6abed9 to f363b97 Compare March 23, 2022 11:57
yakutovicha and others added 9 commits April 6, 2022 15:59
1. Set the electronic temperature to 710.5 K
2. Set MGRID CUTOFF to 1800.
3. Set REL_CUTOFF to 80.
4. Set NGRIDS to 4.
5. Remove initial magnetisation of the atoms (not used).
* Add MOLOPT basis sets from UZH
* Update to the file version from CP2K release 9.1
* Update CP2K input generator
- Reshuffle database files and add new ones
- Use ScaLAPACK as diagonalization library
- Switch CHOLESKY OFF
- Switch to RUN_TYPE ENERGY, because ENERGY_FORCE does not print the atomic forces currently

* Revise CP2K settings for protocol precise
- Use cutoff 1200 Ry with 4 multi-grids and a relative cutoff of 80
- Use MO instead of MO_CUBES section for MO output
- Remove the MAP_CONSISTENT keyword which has been removed in CP2K v7.1 already

* Update potentials and basis sets
- Use UZH TZV2P MOLOPT basis sets for H-Xe
- Use semi-core GTH PPs for some elements

* Change k point distance to 0.06

- Use a less tight SCF convergence (EPS_SCF 1.0E-7)
In addition, one can link basis set/pseudo specification in the
protocol definition. This will allow specifying multiple protocols
that differ only by the choice of basis set/pseudo.
* Always use ScaLAPACK for matrix multiplications instead of the default ELPA
* Write wavefunction restart file after each 5 SCF iteration steps (instead of 20)
* Add revised GTH PPs (GTH_POTENTIALS_PSI).
* Add protocol and database file for the revised GTH pseudopotentials
* Set EXTENDED_FFT_LENGTHS to `True`.
* Increase CUTOFF from 1200 to 2400
* Write notification about restarting file operations (LOG_PRINT_KEY).
@yakutovicha yakutovicha force-pushed the cp2k/protocols-revision branch from cb7fb94 to 930c385 Compare April 6, 2022 15:59
aiida_common_workflows/workflows/relax/cp2k/generator.py Outdated Show resolved Hide resolved

## Lowering runtime by 5 minutes to let CP2K gracefully finish the calculation.
walltime = engines['relax']['options']['max_wallclock_seconds']
walltime = max(300, walltime - 300)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add CP2K specific parameters such that a user using the common workflows can override it easily?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is for a different PR. The big idea of ACWF is having the same input for different codes. I am not sure whether code-fine-tuning options are welcome at all.

Maybe @sphuber can comment on this.

aiida_common_workflows/workflows/relax/cp2k/generator.py Outdated Show resolved Hide resolved
aiida_common_workflows/workflows/relax/cp2k/generator.py Outdated Show resolved Hide resolved
@bosonie
Copy link
Collaborator

bosonie commented Jul 5, 2023

@dev-zero @yakutovicha since the paper is now accepted and we are ready for final answer to reviewer, it became quite urgent to make a release with all the elements to reproduce the results of the caper. Could you please finish up this PR within the week? Thanks!

Comment on lines 158 to 159
'fast', 'moderate', 'precise', 'verification-PBE-v1-DZVP-GTH', 'verification-PBE-v1-DZVP-GTH-rev',
'verification-PBE-v1-TZV2P-GTH'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also no have verification-pbe-v1 here, for consistency with all the others? Could just function as an alias if it really points to one of the specific versions you already have added here. I take it the verification study was run with just one of these protocols? Or do you need all of them depending on the structure you are running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will double-check, but I guess the protocol that was used for the final calculation is verification-PBE-v1-TZV2P-GTH - I can rename it to "verification-pbe-v1".

The other two "verification-PBE.." could probably be removed. They were used while testing different parameters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got the confirmation - indeed, only verification-PBE-v1-TZV2P-GTH was used to produce the final results.

@yakutovicha yakutovicha marked this pull request as ready for review July 11, 2023 14:10
Copy link
Contributor

@dev-zero dev-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thanks a lot!

Copy link
Collaborator

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @yakutovicha and @dev-zero

@sphuber sphuber merged commit 7d7cc9f into master Jul 11, 2023
@sphuber sphuber deleted the cp2k/protocols-revision branch July 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants