Skip to content

Commit

Permalink
setup: move away from legacy build backend (#4790)
Browse files Browse the repository at this point in the history
The `pyproject.toml` was originally added in ca75832 
without specifying a backend, which implicitly defaults to the legacy `setuptools.build_meta:__legacy__` one. 
This choice was made explicit in a2bebb4 

This can lead to issues when using a *system* version of setuptools
< 40.8.0, see [1].
We believe there is no good reason for sticking with the legacy build system.

I've tested that the `reentry_register` hook still works with the new
build backend.

[1] pypa/setuptools#1694 (comment)
  • Loading branch information
ltalirz authored Mar 5, 2021
1 parent 976876f commit d00b4fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = ["setuptools>=40.8.0", "wheel", "reentry~=1.3", "fastentrypoints~=0.12"]
build-backend = "setuptools.build_meta:__legacy__"
build-backend = "setuptools.build_meta"

[tool.pylint.master]
load-plugins = "pylint_django"
Expand Down
2 changes: 1 addition & 1 deletion utils/dependency_management.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def update_pyproject_toml():
'requires': ['setuptools>=40.8.0', 'wheel',
str(reentry_requirement), 'fastentrypoints~=0.12'],
'build-backend':
'setuptools.build_meta:__legacy__',
'setuptools.build_meta',
})

# write the new file
Expand Down

0 comments on commit d00b4fa

Please sign in to comment.