ORM: Cache the logger adapter for ProcessNode

The logger adapter was recreated each time the `logger` property of the
`ProcessNode` was invoked. It is now created once in the `logger`
property. The created logger adapter is assigned to the `_logger_adapter`
attribute such that it can simply be returned at the next invocation.

The initialization of the adapter cannot be done in the constructor as
that route is not taken if an existing node is loaded from the database.

Finally, the `logger` property only creates and returns the adapter when
the node is stored. Otherwise it simply returns the base logger instance.
This is because the logger adapter only works for stored nodes and if it
were instantiated at the point when the node is unstored, it would not
be regenerated once the node is stored, and so the `DbLogHandler` will
never be able to persist log messages to the database.

src/aiida/orm/nodes/process/process.py

@@ -8,7 +8,10 @@
 ###########################################################################
 """Module with `Node` sub class for processes."""
 
+from __future__ import annotations
+
 import enum
+import logging
 from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Type, Union
 
 from plumpy.process_states import ProcessState
@@ -163,6 +166,11 @@ class ProcessNode(Sealable, Node):
 
     _unstorable_message = 'only Data, WorkflowNode, CalculationNode or their subclasses can be stored'
 
+    # This is set on the instance the first time the ``logger`` property is called. It cannot be initialized in the
+    # constructor because that would not go for instances that are loaded from the database which do not pass through
+    # the constructor.
+    _logger_adapter: logging.LoggerAdapter | None = None
+
     def __str__(self) -> str:
         base = super().__str__()
         if self.process_type:
@@ -251,7 +259,16 @@ def logger(self):
         """
         from aiida.orm.utils.log import create_logger_adapter
 
-        return create_logger_adapter(self._logger, self)
+        # If the node is not yet stored, there is no point in creating the logger adapter yet as the ``DbLogHandler``
+        # it configures only is triggered for stored nodes otherwise it cannot link the log message to the node.
+        if not self.pk:
+            return self._logger
+
+        # First time the property is called after the node is stored, create the logger adapter
+        if self._logger_adapter is None:
+            self._logger_adapter = create_logger_adapter(self._logger, self)
+
+        return self._logger_adapter
 
     @classmethod
     def recursive_merge(cls, left: dict[Any, Any], right: dict[Any, Any]) -> None: