Disable caching for inline calculations

[greschd]

Fixes #1871

Caching on inline calculations was broken since the switch to using the workfunction for their implementation, although unfortunately in a way that was not caught by the tests (see #1871).

Since caching isn't implemented for the workfunction, there is not immediate way to fix this. It's probably possible, but will work correctly only if the user adheres to the design rules for inline calcs, for example to not rely on some external parameter in the calculation.

Given all this, and the fact that inline calcs are supposed to be very fast operations anyway, the best course of action right now seems to me to just disable caching for the InlineCalculation.

[giovannipizzi]

Makes sense to me - @sphuber do you agree?

[codecov-io]

Codecov Report

Merging #1872 into develop will increase coverage by 5.31%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop   #1872      +/-   ##
==========================================
+ Coverage    61.38%   66.7%   +5.31%     
==========================================
  Files          320     320              
  Lines        32549   33420     +871     
==========================================
+ Hits         19981   22293    +2312     
+ Misses       12568   11127    -1441

Impacted Files	Coverage Δ
...a/orm/implementation/general/calculation/inline.py	62.5% <100%> (ø)	⬆️
aiida/cmdline/utils/shell.py	16.94% <0%> (-83.06%)	⬇️
aiida/cmdline/utils/query/mapping.py	74.39% <0%> (-4.72%)	⬇️
...implementation/general/calculation/job/__init__.py	40.32% <0%> (-3.38%)	⬇️
aiida/common/caching.py	91.86% <0%> (-2.33%)	⬇️
aiida/daemon/execmanager.py	7.85% <0%> (-0.75%)	⬇️
aiida/cmdline/params/options/__init__.py	100% <0%> (ø)	⬆️
aiida/common/setup.py	74.84% <0%> (+0.2%)	⬆️
aiida/orm/implementation/general/node.py	78.5% <0%> (+0.31%)	⬆️
aiida/work/processes.py	95.67% <0%> (+0.32%)	⬆️
... and 39 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddfffc...1ee37b9. Read the comment docs.

[greschd]

We had some more discussion at #1871, but I'm not sure what the conclusion is.

[sphuber]

Just that I wasn't sure of the exact reason for it breaking and I wanted to investigate it better but sadly I forgot a bit about it. I would be ok with merging this, but we should maybe open another issue to investigate the caching of function calculations.

[coveralls]

Coverage increased (+7.9%) to 55.788% when pulling d0166c2 on greschd:disable_caching_for_inlinecalcs into a86dfed on aiidateam:release_v0.12.3.

[sphuber]

Approving this, since the actual problem is fixed in develop which will become v1.0.0 once released