Renaming and reorganizing some verdi commands
#2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
previously approved these changes
Nov 15, 2018
|
There is a weird error Also, alerting @sphuber and @ConradJohnston to sync on this as here there are some changes on the QueryBuilder and @ConradJohnston is updating the kwargs, so depending on who merges first, at the end we should double check that the QB flags are always properly named. |
…erdi calcjob` The functionality that was in `verdi calculation` mostly applied only to calculation jobs, and not to any other calculations as generated for example with the calcfunction decorator. Other sub commands were generic enough to be put in `verdi process`. Here we move this common functionality such as the commands `show` and `logshow` to the `verdi process` command, renaming `logshow` to `report`. The remaining commands that apply to job calculations `inputls`, `inputcat`, `outputls`, `outputcat`, `gotocomputer` and `cleanworkdir` are moved to `verdi calcjob`. The old commands in `verdi calculation` are all deprecated and automatically forwarded to the new commands.
The majority of functionality in `verdi work` that was not already deprecated and moved to `verdi process`, such as `status` and `report` are generally applicable to all process types. Therefore it makes sense to move everything there and deprecate the `verdi work` command.
sphuber
force-pushed
the
fix_2175_verdi_commands_rename
branch
from
81cc780 to
669ac7b
Compare
This should serve as the central command to list registered plugins for the various entry point groups, instead of each verdi command having its own dedicated sub command. The existing sub commands for `verdi data` `verdi calculation` and `verdi work` have been deprecated and piped through to the new `verdi plugin` command.
sphuber
force-pushed
the
fix_2175_verdi_commands_rename
branch
from
669ac7b to
419a4c5
Compare
giovannipizzi
approved these changes
Nov 16, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175