-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add append and prepend to aiida_local_code_factory #3831
Conversation
Looks useful to me, thanks! To keep consistent with the naming of the Code attribute, I would probably call the keyword arguments |
Thanks @greschd. I just applied your suggestion and pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just the docstring needs updating also. I'll leave it up to @ltalirz to merge this.
Codecov Report
@@ Coverage Diff @@
## develop #3831 +/- ##
==========================================
- Coverage 77.16% 69.2% -7.97%
==========================================
Files 458 458
Lines 33766 33770 +4
==========================================
- Hits 26056 23369 -2687
- Misses 7710 10401 +2691
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thanks @pzarabadip 👍
This PR aims to add the ability of adding
append_text
andprepend_text
to theaiida_local_code_factory
which is need in writing tests for codes where we need to have these extra fields.