-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github action of transifex upload #3958
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3958 +/- ##
========================================
Coverage 78.31% 78.31%
========================================
Files 461 461
Lines 34076 34076
========================================
Hits 26687 26687
Misses 7389 7389
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I just have two requests to add some comments to provide a little bit more context.
739d655
to
29dc84b
Compare
There seems no way to manually trigger the action. So have to wait until next release to make sure this workflow is working properly. 🤞 I trigger it in a hack way and it failed, maybe since the secret keys are not set. |
29dc84b
to
8cdc32a
Compare
a07ac06
to
11eacfd
Compare
I recall that the And API token: https://www.transifex.com/user/settings/api/ As a reference, the context of my
Edit: I redacted the password. csa |
@unkcpz Did you post the actual credentials? In this case, please reset this password immediately and send the new password to my personal email. Thank you. Edit: In either case, please send the actual credentials to my personal email, thank you. |
@unkcpz It might be a good idea for us to debug this workflow before we merge it by simply running it temporarily on @ltalirz Can you verify that the secrets have been added to the repository? |
Sorry guys, I've added them now (user: api, password: the api token). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to run the workflow on push and then re-request review. Thx!
ab527f1
to
ee241ba
Compare
It is strange. I can successfully upload the pot to my account check here (and the workflow file with only project name different), but with all similar processes, still failed when setting and uploading to aiida account. I got: @ltalirz Can you reconfirm you add and set secrets:
Thanks! |
Hi @unkcpz , sorry about this, I believe the token I had stored was missing a few characters. I've also changed your status in the aiida docs to project maintainer in case it is useful at any point. |
ee241ba
to
1a2285c
Compare
emmm... unfortunately, same error here. Maybe, it is not allowed to using secrets keys in pull request actions? It cause anyone can access and use the secret token by just making a pull request, which is unsafe. In this case, could you help to make a push for test?
Thanks! 😄 |
1a2285c
to
0aaa72d
Compare
Ah sorry that I missed that. The secret is indeed not available for pull requests. We will need to push directly to the repository. I'll do that. |
@unkcpz Just pushed to |
Seems to have worked, right? |
0aaa72d
to
b2af3f3
Compare
It works now. Cheers! And change trigger event back to release, ready to be merged. Thank you guys! 😃 |
However, I concerned if |
The release event is going to trigger the workflow with the appropriate permissions. So don't worry about that. |
Migrate transifex integration from travis.ci to github action. @csadorf
I am not sure whether
TRANSIFEX_USER
andTRANSIFEX_PASSWORD
set previously still available. You may need to set them if not.