Adding entry point group aiida.tools.data.orbitals to the mapping
#4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that there are more missing:
Should we add those as well? |
Codecov Report
@@ Coverage Diff @@
## develop #4395 +/- ##
===========================================
- Coverage 79.40% 79.39% -0.00%
===========================================
Files 480 480
Lines 35080 35080
===========================================
- Hits 27853 27850 -3
- Misses 7227 7230 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Just a minor nitpick: I believe you're adding a new entry point group here (just relevant for the commit message). |
giovannipizzi
changed the title
aiida.tools.data.orbitals to the mappingaiida.tools.data.orbitals to the mapping
Some new entrypoints had been introduced, but they weren't in the mapping, so they couldn't be accessed for instance with `verdi plugin list`.
giovannipizzi
force-pushed
the
fix_missing_new_entrypoint
branch
from
ed290e6 to
3a7e44e
Compare
ramirezfranciscof
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new entrypoint had been introduced, but it wasn't in the mapping,
so it couldn't be accessed for instance with
verdi plugin list.