Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: increase minimum version requirement plumpy~=0.15.1 #4398

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 25, 2020

Fixes #4346

The patch release of plumpy comes with a simple fix that will prevent
the printing of many warnings when running processes. So although not
critical, it does improve user experience.

The patch release of `plumpy` comes with a simple fix that will prevent
the printing of many warnings when running processes. So although not
critical, it does improve user experience.
@sphuber sphuber requested a review from ltalirz September 25, 2020 11:09
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sphuber !

@sphuber
Copy link
Contributor Author

sphuber commented Sep 25, 2020

@ltalirz apparently plumpy==0.15.1 wasn't built on conda yet. Is there a way to trigger the PR? Normally this is done automatically by the bot, isn't it?

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #4398 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4398      +/-   ##
===========================================
- Coverage    79.22%   79.22%   -0.00%     
===========================================
  Files          475      475              
  Lines        34826    34822       -4     
===========================================
- Hits         27588    27583       -5     
- Misses        7238     7239       +1     
Flag Coverage Δ
#django 73.07% <ø> (-<0.01%) ⬇️
#sqlalchemy 72.29% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/engine/daemon/runner.py 79.32% <0.00%> (-3.44%) ⬇️
aiida/orm/nodes/node.py 81.65% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1c6fd...2452ec6. Read the comment docs.

@sphuber sphuber merged commit dac8156 into aiidateam:develop Sep 25, 2020
@sphuber sphuber deleted the fix/4346/bump-plumpy branch September 25, 2020 14:20
sphuber added a commit to sphuber/aiida-core that referenced this pull request Sep 25, 2020
…iidateam#4398)

The patch release of `plumpy` comes with a simple fix that will prevent
the printing of many warnings when running processes. So although not
critical, it does improve user experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy but harmless exceptions reported when interpreter, that has run processes, ends
2 participants