Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move pylint configuration to pyproject.toml #4411

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 27, 2020

Fixes #4409

This is supported by pylint as of v2.5.

This is supported by `pylint` as of v2.5.
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #4411 into develop will decrease coverage by 0.01%.
The diff coverage is 90.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4411      +/-   ##
===========================================
- Coverage    79.22%   79.22%   -0.00%     
===========================================
  Files          475      475              
  Lines        34827    34826       -1     
===========================================
- Hits         27589    27588       -1     
  Misses        7238     7238              
Flag Coverage Δ
#django 73.07% <77.28%> (+0.01%) ⬆️
#sqlalchemy 72.29% <77.28%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...jsite/db/migrations/0015_invalidating_node_hash.py 100.00% <ø> (ø)
.../backends/djsite/db/migrations/0018_django_1_11.py 100.00% <ø> (ø)
...db/migrations/0019_migrate_builtin_calculations.py 100.00% <ø> (ø)
...s/djsite/db/migrations/0020_provenance_redesign.py 69.24% <ø> (ø)
.../0021_dbgroup_name_to_label_type_to_type_string.py 100.00% <ø> (ø)
...rations/0022_dbgroup_type_string_change_content.py 100.00% <ø> (ø)
.../migrations/0023_calc_job_option_attribute_keys.py 100.00% <ø> (ø)
...backends/djsite/db/migrations/0024_dblog_update.py 93.50% <ø> (ø)
...db/migrations/0025_move_data_within_node_module.py 100.00% <ø> (ø)
...migrations/0026_trajectory_symbols_to_attribute.py 96.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b5385...120b39b. Read the comment docs.

Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sphuber!

@sphuber sphuber merged commit 65ad067 into aiidateam:develop Sep 28, 2020
@sphuber sphuber deleted the fix/4409/pylint-conf-to-pyproject branch September 28, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pylint configuration to pyproject.toml
2 participants