Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test direct installation via conda. #5029

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jul 30, 2021

Instead of just testing whether we can install into the environment
defined by environment.yaml.

@csadorf
Copy link
Contributor Author

csadorf commented Jul 30, 2021

This shows that aiida-core cannot be installed into a Python 3.9 environment, see the test-install log:

2021-07-30T11:43:17.0115553Z python-3.8.10        | 26.2 MB   |            |   0% 
2021-07-30T11:43:17.1180013Z python-3.8.10        | 26.2 MB   | #9         |  19% 
2021-07-30T11:43:17.2667417Z python-3.8.10        | 26.2 MB   | ####4      |  44% 
2021-07-30T11:43:17.3697297Z python-3.8.10        | 26.2 MB   | ######5    |  65% 
2021-07-30T11:43:21.3715764Z python-3.8.10        | 26.2 MB   | #########7 |  97% 
2021-07-30T11:43:21.3717265Z python-3.8.10        | 26.2 MB   | ########## | 100% `

This is caused by aio-pika package which is constrained to ~6.6:

$ conda create -n aiida-py39 python=3.9 aiida-core
Collecting package metadata (current_repodata.json): \done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: /
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package python conflicts for:
aiida-core -> aio-pika~=6.6 -> python[version='2.7.*|3.5.*|3.6.*|>=3.6|>=3.9,<3.10.0a0|>=3|>=3.5,<3.6.0a0|=2.7|>=3.5|>=2.7|3.4.*|3.8.*|3.7.*']
python=3.9
aiida-core -> python[version='>=2.7,<2.8.0a0|>=3.5|~=3.7|>=3.6,<3.7.0a0|>=3.8,<3.9.0a0|>=3.7,<3.8.0a0']

This is odd, because the package is no-arch as of 6.7.1 which would be compatible with our constraint. Installing aio-pika in isolation works flawlessly:

conda create -n aio-pika python=3.9 aio-pika~=6.6

and will install version 6.8.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #5029 (4ccdfc1) into develop (a468519) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4ccdfc1 differs from pull request most recent head 9e220e4. Consider uploading reports for the commit 9e220e4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5029      +/-   ##
===========================================
+ Coverage    80.23%   80.23%   +0.01%     
===========================================
  Files          515      515              
  Lines        36757    36757              
===========================================
+ Hits         29489    29490       +1     
+ Misses        7268     7267       -1     
Flag Coverage Δ
django 74.72% <ø> (ø)
sqlalchemy 73.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.66% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f55a25...9e220e4. Read the comment docs.

@csadorf csadorf marked this pull request as ready for review August 3, 2021 09:25
@csadorf csadorf requested a review from ltalirz August 3, 2021 09:26
@csadorf
Copy link
Contributor Author

csadorf commented Aug 3, 2021

I'm tracking the current failure to install with conda in combination with python=3.9 in #5037 .

@ltalirz
Copy link
Member

ltalirz commented Aug 3, 2021

could this be related to conda-forge/aiida-core-feedstock#41 ?

Instead of just testing whether we can install into the environment
defined by environment.yaml.
@csadorf csadorf force-pushed the ci/test-direct-conda-installation branch from 4ccdfc1 to 9e220e4 Compare August 3, 2021 10:25
@csadorf csadorf requested a review from ltalirz August 3, 2021 11:19
@ltalirz
Copy link
Member

ltalirz commented Aug 3, 2021

Thanks, for me it would be ok to test this here but as mentioned if this breaks it will need fixes in a different repo.

Also, if I understand correctly, the test would fail now - do you still want to merge this?

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I see it just installs python3.8

ok for me

@csadorf csadorf merged commit 3ff1d1c into develop Aug 3, 2021
@csadorf csadorf deleted the ci/test-direct-conda-installation branch August 3, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants