🐛 FIX: listdir method with pattern for SSH #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `listdir` method of the SSH transport plugin was using `glob.glob` instead of `self.glob` when a pattern was specified. This is wrong because it's listing files locally and not on the remote. The tests passed because they are running on localhost. Also, this method is probably never called by AiiDA so it went unnoticed. This commit fixes the issue. I'm not sure if there is a simple way to fix the tests - probably we should run them against a docker container or at least a chroot'ed folder? This might be another issue to be opened though. Fixes aiidateam#5244
Codecov Report
@@ Coverage Diff @@
## develop #5252 +/- ##
========================================
Coverage 81.38% 81.38%
========================================
Files 529 529
Lines 37008 37008
========================================
Hits 30117 30117
Misses 6891 6891
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
chrisjsewell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
listdirmethod of the SSH transport plugin was usingglob.globinstead ofself.globwhen a pattern was specified.This is wrong because it's listing files locally and not on the
remote.
The tests passed because they are running on localhost.
Also, this method is probably never called by AiiDA so it went unnoticed.
This commit fixes the issue. I'm not sure if there is a simple
way to fix the tests - probably we should run them against a
docker container or at least a chroot'ed folder? This might be
another issue to be opened though.
Fixes #5244