DirectScheduler: Add ? as JobState.UNDETERMINED
#6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sphuber I was running into this problem quite regularly. I looked into it, and it seems that on MacOS the |
sphuber
requested changes
May 28, 2023
When running a process via `engine.run` on a MacOS `localhost` using the `core.direct` scheduler, warnings are often raised regarding an "unrecognised job state `?`'. This is related to the fact that on MacOS the `ps` command is sometimes not able to determine the process state temporarily, and prints a `?` in the `STAT` column, see: https://apple.stackexchange.com/q/460394/497071 Here we simply add the `?` as one of the possible outputs of the `ps` commmand in the `_MAP_STATUS_PS` dictionary, mapping it to `JobState.UNDETERMINED`.
mbercx
force-pushed
the
fix/3107/unrecognised-job
branch
from
c0537e6 to
151af2d
Compare
sphuber
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3107
When running a process via
engine.runon a MacOSlocalhostusing thecore.directscheduler, warning are often raised regarding an "unrecognised job state?'. This is related to the fact that on MacOS thepscommand is sometimes not able to determine the process state temporarily, and print a?in theSTATcolumn.Here we simply add the
?as one of the possible outputs of thepscommmand in the_MAP_STATUS_PSdictionary, mapping it toJobState.UNDETERMINED.