Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Update #6306

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Logo Update #6306

merged 8 commits into from
Mar 6, 2024

Conversation

SharanRP
Copy link
Contributor

@SharanRP SharanRP commented Mar 5, 2024

closes #aiidateam/aiida-website#59 (comment)

Twitter logo updated
@eimrek

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SharanRP . As you can see from the built docs, this isn't sufficient. The current docs are built using pydata-sphinx-theme~=0.13.3, however, support for the new X logo in the fontawesome icon set was added until this PR, which was released with v0.15.0. So you will have to update the pydantic-spinx-theme dependency to this version at least.

@SharanRP
Copy link
Contributor Author

SharanRP commented Mar 6, 2024

I have updated the pydata-spinx-theme to 0.15.1

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now the fix works, thanks @SharanRP

@sphuber sphuber merged commit 5e4f60d into aiidateam:main Mar 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants