-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport & Engine: AsyncTransport
plugin
#6626
Open
khsrali
wants to merge
38
commits into
aiidateam:main
Choose a base branch
from
khsrali:async-transport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b59d999
♻️ Allow for file uploads/downloads to be async
chrisjsewell 0c42841
Update test_execmanager.py
chrisjsewell 6cb4d9e
Merge remote-tracking branch 'upstream/main' into async-run
chrisjsewell 14cbd29
update run methods
chrisjsewell e9361bb
Merge branch 'main' into async-transport
khsrali 6811098
async transport, the first implementation
khsrali 5fdde51
asynchrounous counterparts are added to transport.py
khsrali ccc545e
Giovanni's review applied
khsrali f187fdc
adopted tests
khsrali 565724d
docstring updated
khsrali 6e350e7
added computer test for ssh_async
khsrali 03ccc30
review applied
khsrali 178bf7b
chnage from machine to machine_
khsrali cc0bc5c
review applied
khsrali 3210c27
copy-remote adopted with behaviour of asyncssh
khsrali 76aaf53
Merge branch 'main' into async-transport
khsrali 65f0663
remove str() use from test_all_plugins
khsrali a809b98
copy() are now aligned with fresh development on asyncssh
khsrali 38cfc24
fixed some stupid issues
khsrali 799e0f8
plumpy hook pointing to async-run branch, now
khsrali 665a163
Merge branch 'main' into async-transport
khsrali 0837193
updated uv lock
khsrali 1b96110
Fixing uv.lock file for the depedencies from a github repo
agoscinski 3aa0031
Merge branch 'main' into async-transport
khsrali a68240c
fix conflicts
khsrali 520e58e
fixed afew self blocking calls in copy_async()
khsrali 22eb929
Merge branch 'main' into async-transport
khsrali 90718f4
fix rtd
khsrali 343cf9c
fix uv
khsrali 482eeca
escape for bash on command
khsrali 5e29e5b
fixed many warnings of rtd
khsrali a5ff84d
Merge branch 'main' into async-transport
khsrali 1761d94
implement max_io_allowed
khsrali cf01ac0
Merge branch 'main' into async-transport
khsrali 6627b21
update asyncssh dependency
khsrali 2ebf945
plumpy dependency pin the exact commit
khsrali fb384ac
Merge branch 'main' into async-transport
khsrali d6176fd
plumpy -> 0.23.0
khsrali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,12 +4,13 @@ | |||||
|
||||||
import tempfile | ||||||
from pathlib import Path | ||||||
from typing import Union | ||||||
|
||||||
from aiida.orm import CalcJobNode | ||||||
from aiida.transports import Transport | ||||||
from aiida.transports import AsyncTransport, Transport | ||||||
|
||||||
|
||||||
def always_kill(node: CalcJobNode, transport: Transport) -> str | None: | ||||||
def always_kill(node: CalcJobNode, transport: Union['Transport', 'AsyncTransport']) -> str | None: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for other places, but it is fine to leave it as this, I think we will find a time to change them all. So please ignore my comment above. |
||||||
"""Retrieve and inspect files in working directory of job to determine whether the job should be killed. | ||||||
|
||||||
This particular implementation is just for demonstration purposes and will kill the job as long as there is a | ||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you make a PR there so we can do a new release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! Please review here: aiidateam/plumpy#272