Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xy data documentation #6736

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ayushjariyal
Copy link
Contributor

fix# #6731

change the documentation for xy data.

@unkcpz
Copy link
Member

unkcpz commented Feb 13, 2025

Sorry for the late reply. @ayushjariyal could you resolve the conflict and fix the pre-commit error. We'll review it then.

@ayushjariyal
Copy link
Contributor Author

@unkcpz I accidentally deleted my previous branch and can no longer undo my previous changes, so I have opened a new PR. Could you please review it?

@unkcpz
Copy link
Member

unkcpz commented Feb 13, 2025

Sorry, I think you didn't delete it. It still here https://github.com/ayushjariyal/aiida-core/tree/issue_XyData_documentation

@ayushjariyal
Copy link
Contributor Author

Oh, I see! Thanks for letting me know. I’ll check on it.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (d2fbf21) to head (deddfc9).

Files with missing lines Patch % Lines
src/aiida/orm/nodes/data/array/xy.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6736      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.00%     
==========================================
  Files         564      564              
  Lines       42526    42527       +1     
==========================================
- Hits        33222    33220       -2     
- Misses       9304     9307       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayushjariyal ayushjariyal force-pushed the issue_XyData_documentation branch 2 times, most recently from 329bc35 to a9e7df5 Compare February 14, 2025 02:53
@ayushjariyal ayushjariyal force-pushed the issue_XyData_documentation branch from cffc576 to ce6f8ea Compare February 14, 2025 12:18
@ayushjariyal ayushjariyal force-pushed the issue_XyData_documentation branch from e3888a7 to 71a6017 Compare February 14, 2025 12:42
@ayushjariyal ayushjariyal force-pushed the issue_XyData_documentation branch from 0be89c2 to fb66e7d Compare February 14, 2025 13:13
@ayushjariyal
Copy link
Contributor Author

@unkcpz I am not able to understand why these checks have failed. Can you please help me figure that out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants