Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cp2k from conda #170

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Install cp2k from conda #170

merged 9 commits into from
Mar 27, 2024

Conversation

yakutovicha
Copy link
Contributor

@yakutovicha yakutovicha commented Nov 21, 2022

The conda installation comes with sirius library support.

@yakutovicha yakutovicha changed the title Update docker setup Install cp2k from conda Mar 19, 2024
@yakutovicha yakutovicha marked this pull request as ready for review March 19, 2024 15:33
Copy link
Collaborator

@cpignedoli cpignedoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@yakutovicha
Copy link
Contributor Author

image

At the moment it doesn't work with the ARM architecture


USER aiida

RUN mamba create --yes -c conda-forge -n cp2k cp2k=9.1 && mamba clean --all -f -y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you install the latest version of CP2K?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next step would be to test against multiple versions of cp2k, to make sure the plugin is compatible with all of them.

I am sure the new ones will have issues, so to not blow up the PR I decided to make the change as small as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, would it be possible to also put ARM builds there?

Copy link
Collaborator

@oschuett oschuett Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, would it be possible to also put ARM builds there?

CP2K supports ARM with Linux and macOS. This is also tested on the Dashboard. However, those tests sill use the old Makefile build system. So, adding ARM to the Conda package should be doable, but might require ironing out some CMake issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CP2K supports ARM with Linux and macOS. This is also tested on the Dashboard. However, those tests sill use the old Makefile build system. So, adding ARM to the Conda package should be doable, but might require ironing out some CMake issues.

It is not urgent, but if it could be done at some point - this would be great.

Copy link
Collaborator

@cpignedoli cpignedoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sasha showed me the working version for AMD64

@yakutovicha yakutovicha merged commit f237e46 into main Mar 27, 2024
6 checks passed
@yakutovicha yakutovicha deleted the update/docker-container branch March 27, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants