Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use kind_name as element tag in the xyz file #216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −4
Open

use kind_name as element tag in the xyz file #216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcec6ee
use kind_name as atom symbol
superstar54 May 13, 2024
684235c
update docstring, and write the file directly
superstar54 May 13, 2024
d4901e6
fix pre-commit
superstar54 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions aiida_cp2k/calculations/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,15 @@ def prepare_for_submission(self, folder):

@staticmethod
def _write_structure(structure, folder, name):
"""Function that writes a structure and takes care of element tags."""

xyz = _atoms_to_xyz(structure.get_ase())
"""Function that writes a structure to a xyz file.
The element tags being the names of the kind.
"""
elem_coords = [
f"{site.position[0]:25.16f} {site.position[1]:25.16f} {site.position[2]:25.16f}"
for site in structure.sites
]
xyz = f"{len(elem_coords)}\n\n"
xyz += "\n".join(map(add, structure.get_site_kindnames(), elem_coords))
with open(folder.get_abs_path(name), mode="w", encoding="utf-8") as fobj:
fobj.write(xyz)

Expand Down Expand Up @@ -475,7 +481,7 @@ def _trajectory_to_xyz_and_cell(trajectory):
if "cells" in trajectory.get_arraynames():
cell = "# Step Time [fs] Ax [Angstrom] Ay [Angstrom] Az [Angstrom] Bx [Angstrom] By [Angstrom] Bz [Angstrom] Cx [Angstrom] Cy [Angstrom] Cz [Angstrom] Volume [Angstrom^3]\n"
cell_vecs = [
f"{stepid+1} {(stepid+1)*0.5:6.3f} {cellvec[0][0]:25.16f} {cellvec[0][1]:25.16f} {cellvec[0][2]:25.16f} {cellvec[1][0]:25.16f} {cellvec[1][1]:25.16f} {cellvec[1][2]:25.16f} {cellvec[2][0]:25.16f} {cellvec[2][1]:25.16f} {cellvec[2][2]:25.16f} {np.dot(cellvec[0],np.cross(cellvec[1],cellvec[2]))}"
f"{stepid+1} {(stepid+1)*0.5:6.3f} {cellvec[0][0]:25.16f} {cellvec[0][1]:25.16f} {cellvec[0][2]:25.16f} {cellvec[1][0]:25.16f} {cellvec[1][1]:25.16f} {cellvec[1][2]:25.16f} {cellvec[2][0]:25.16f} {cellvec[2][1]:25.16f} {cellvec[2][2]:25.16f} {np.dot(cellvec[0], np.cross(cellvec[1], cellvec[2]))}"
for (stepid, cellvec) in zip(stepids, trajectory.get_array("cells"))
]
cell += "\n".join(cell_vecs)
Expand Down
Loading