-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awatiable_builder
decorator
#239
base: main
Are you sure you want to change the base?
Conversation
awatiable_builder
decorator
0e00897
to
2774f56
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 75.75% 79.08% +3.33%
==========================================
Files 70 65 -5
Lines 4615 4959 +344
==========================================
+ Hits 3496 3922 +426
+ Misses 1119 1037 -82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6905686
to
adffe35
Compare
Hi @mbercx , I've created a submission controller using WorkGraph. Could you please review the example above and let me know if it makes sense to you? I'd appreciate your feedback. |
ece97b9
to
98bc7da
Compare
This PR adds an
awatiable_builder
decorator; the decorated function will submit an AiiDA Process and return the ProcessNode.Note: The user needs to use the modified
submit
(from aiida_workgraph.engine.utils import submit
), so that the task can submit the process inside the WorkGraph without using theself.submit
.The primary purpose is to allow the WorkGraph to submit other jobs.
submission_controller
using WorkGraph.Here is an example to submit the PW calculation for a list of structures inside a AiiDA group. The maximum running process is set to 2. Similar to this example from aiida-submission-controller.
WorkGraph
Timeline
We can see that the maximum number of running processes is 2 for all the time.
The examples can be found here:https://github.com/superstar54/aiida-submission-controller/blob/feature/workgraph/examples/workgraph_group.py