Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.23.0 #299

Closed
wants to merge 5 commits into from
Closed

Release 0.23.0 #299

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06c1b93
Release
khsrali Dec 13, 2024
096fb2d
Merge branch 'master' into release/0.23.0
khsrali Dec 16, 2024
b759947
review applied
khsrali Dec 16, 2024
0cfec0d
review applied
khsrali Dec 17, 2024
7eefe06
review applied
khsrali Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
# Changelog

## v0.23.0 - 2024-12-13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe quickly add a comment here what the breaking behavior is.


### Features
- Message builder for constructing message with carrying more information (#291) [[f760b4a]](https://github.com/aiidateam/plumpy/commit/f760b4aaf6a46bbfc13bab88e36271aab122a641)
- Breaking behavior: Direct message constants (`KILL_MSG`, `PAUSE_MSG`, `PLAY_MSG`, `STATUS_MSG`) are replaced with the `MessageBuilder` class methods.

### Bug fixes
- Make `Waiting.resume()` idempotent (#285) [[20e5898]](https://github.com/aiidateam/plumpy/commit/20e5898e0c9037624988fe321e784f4fe38a2e8d)

### Devops
- Make `Process.run` async (#272) [[4611154]](https://github.com/aiidateam/plumpy/commit/4611154c76ac0991bcf7371b21488f4390648c28)
- Breaking behavior: Changes from `Coroutine` to `Awaitable` in function signatures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only the typing annotation was changed, then it won't affect the behavior, since typing annotation is ignored at runtime.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would potentially be breaking the type annotations of packages that use this library. I agree that that is unlikely to happen, but still, this is not really "devops", which should only interest developers of this package and not really consumers of it. But it is not a big deal, leave it where you prefer.

- Breaking behavior: All the `run()` methods across the interface are now asynchronous (async def).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hide this in devops. This should be high up under ### Breaking changes maybe even before features.

- Switch to ruff and other devops improvements (#289) [[55e05e9]](https://github.com/aiidateam/plumpy/commit/55e05e956c9715fb69785d83d0194b65811b4720)



## v0.22.3 - 2024-02-02

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion src/plumpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
# mypy: disable-error-code=name-defined
__version__ = '0.22.3'
__version__ = '0.23.0'

import logging

Expand Down
Loading