Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract callback in quote; deprecate callback in symbol #150

Merged
merged 28 commits into from
Dec 20, 2022
Merged

feat: extract callback in quote; deprecate callback in symbol #150

merged 28 commits into from
Dec 20, 2022

Conversation

aileot
Copy link
Owner

@aileot aileot commented Dec 13, 2022 •
edited
Loading

command! macro should also accept quoted callback for the analogical usage.

  • feat: deprecate callback in symbol; instead, encourage `foobar format.

    • fix: exclude vim.fn.foobar.
      • keymap
      • autocmd

  • test: confirm that ->fn can treat user-made macros properly.

  • feat: `foo -> foo

    • autocmd
    • keymap
    • command

  • feat: `(foo :bar :baz) -> #(foo :bar :baz)

    • autocmd
    • keymap
    • command

  • perf: `vim.fn.foobar -> "foobar"

    • autocmd
    • keymap

  • test: add specs

    • autocmd
    • keymap
    • command

  • docs: update

    • autocmd
    • keymap
    • command

Blocking #143

@aileot aileot force-pushed the feat-quote_for_callback branch 12 times, most recently from 33ae2c3 to 1fd18f4 Compare December 14, 2022 15:07
@aileot aileot marked this pull request as draft December 14, 2022 22:00
@aileot aileot changed the title feat: quote for callbacks feat: extract quote for callbacks; deprecate callback in symbol Dec 15, 2022
@aileot aileot changed the title feat: extract quote for callbacks; deprecate callback in symbol feat: extract quote for callback; deprecate callback in symbol Dec 15, 2022
@aileot aileot changed the title feat: extract quote for callback; deprecate callback in symbol feat: extract callback in quote; deprecate callback in symbol Dec 15, 2022
@aileot
Copy link
Owner Author

aileot commented Dec 15, 2022 •
edited
Loading

Blocked by #151
Rebased the commits into this branch instead.
Close #151

@aileot aileot mentioned this pull request Dec 15, 2022
Closed
3 tasks
@aileot aileot mentioned this pull request Dec 15, 2022
Closed
9 tasks
@aileot
test(keymap): add specs for quoted callback patterns
9457c02
@aileot
test(autocmd): define vim function Test() for every test
6a5380d
@aileot
test(autocmd): add specs for quoted callback patterns
2f3ced5
@aileot
test(command): assert "Foo" is undefined before each tests
c3da37d
@aileot
test(command): add specs for quoted callback
cf87f6e
@aileot
refactor(util): manipulate quote list simpler
40f2a08
@aileot
test(command): fix as update for quote handling
a95591a
@aileot
docs(macros): update for quoted list
0526e2e
@aileot
docs(macros): update sample codes
3d0505b
@aileot
docs(macros): update for quoted callback
6e5a66c
@aileot
docs(macros): update note for Vim script function
6a31e52
@aileot
docs(macros): udpate "Deprecated"
2a512dd
@aileot
feat(keymap): deprecate symbol as identifer for callback function
205209a
@aileot
feat(autocmd): deprecate callback in symbol for function
a900a54
@aileot
test: replace # with "`" as behaviour has changed
4dfe7e8
@aileot aileot marked this pull request as ready for review December 20, 2022 12:45
@aileot aileot merged commit 98f0dcd into main Dec 20, 2022
@aileot aileot deleted the feat-quote_for_callback branch December 20, 2022 12:48
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
@github-actions github-actions bot mentioned this pull request Feb 18, 2024
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aileot